fix: Ensure we exit after saying Bye Bye#33
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where a SIGINT signal wasn't completely stopping the service in certain contexts like Rails runner, causing the service to restart after shutdown. The fix ensures the process explicitly exits after the shutdown procedure completes.
- Renamed
wake_main_threadtowake_main_thread_and_exit!to reflect its new behavior - Added explicit
exitcall in anensureblock to guarantee process termination
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ejpreciado
approved these changes
Aug 15, 2025
BryceARich
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain contexts (rails runner) a SIGINT was somehow
not stopping the service completely. It would stop,
then wake the main thread, and start right back up.
This ensures an explicit exit.